Replace fmt.Sprint with strconv.Itoa, specify slice capacity

Uber's Go style guide outlines a slight performance benefit when using strconv over fmt: https://github.com/uber-go/guide/blob/dc025303c14891f54d1847396379548773e6123e/style.md#prefer-strconv-over-fmt Also specifiying slice capacity when it is known beforehand: https://github.com/uber-go/guide/blob/dc025303c14891f54d1847396379548773e6123e/style.md#specifying-slice-capacity Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-09-29 13:52:12 -04:00
parent 022cfd5cb1
commit 15ee94fbbe
7 changed files with 15 additions and 8 deletions
@@ -58,8 +58,9 @@ func (n *SubredditNames) UnmarshalJSON(data []byte) error {
 		return err
 	}

-	for _, sr := range subreddits {
-		*n = append(*n, sr.Name)
+	*n = make(SubredditNames, len(subreddits))
+	for i, sr := range subreddits {
+		(*n)[i] = sr.Name
 	}

 	return nil