guy176251/reddit-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use assert package for tests, much cleaner

Browse Source 
Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
This commit is contained in:
Vartan Benohanian
2020-05-29 19:50:52 -04:00
parent 1d1118517b
commit 3169b4be19
7 changed files with 103 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vote_test.go
+23 -28
View File
@@ -4,8 +4,9 @@ import (
"fmt"
"net/http"
"net/url"
"reflect"
"testing"
"github.com/stretchr/testify/assert"
)
func TestVoteServiceOp_Up(t *testing.T) {
@@ -13,25 +14,23 @@ func TestVoteServiceOp_Up(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/vote", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, http.MethodPost)
assert.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
form.Set("dir", fmt.Sprint(upvote))
form.Set("rank", "10")
_ = r.ParseForm()
if expect, actual := form, r.PostForm; !reflect.DeepEqual(expect, actual) {
t.Fatalf("got unexpected value\nexpect: %s\nactual: %s", Stringify(expect), Stringify(actual))
}
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.PostForm)
fmt.Fprint(w, `{}`)
})
_, err := client.Vote.Up(ctx, "t3_test")
if err != nil {
t.Fatalf("got unexpected error: %v", err)
}
res, err := client.Vote.Up(ctx, "t3_test")
assert.NoError(t, err)
assert.Equal(t, http.StatusOK, res.StatusCode)
}
func TestVoteServiceOp_Down(t *testing.T) {
@@ -39,25 +38,23 @@ func TestVoteServiceOp_Down(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/vote", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, http.MethodPost)
assert.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
form.Set("dir", fmt.Sprint(downvote))
form.Set("rank", "10")
_ = r.ParseForm()
if expect, actual := form, r.PostForm; !reflect.DeepEqual(expect, actual) {
t.Fatalf("got unexpected value\nexpect: %s\nactual: %s", Stringify(expect), Stringify(actual))
}
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.PostForm)
fmt.Fprint(w, `{}`)
})
_, err := client.Vote.Down(ctx, "t3_test")
if err != nil {
t.Fatalf("got unexpected error: %v", err)
}
res, err := client.Vote.Down(ctx, "t3_test")
assert.NoError(t, err)
assert.Equal(t, http.StatusOK, res.StatusCode)
}
func TestVoteServiceOp_Remove(t *testing.T) {
@@ -65,23 +62,21 @@ func TestVoteServiceOp_Remove(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/vote", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, http.MethodPost)
assert.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
form.Set("dir", fmt.Sprint(novote))
form.Set("rank", "10")
_ = r.ParseForm()
if expect, actual := form, r.PostForm; !reflect.DeepEqual(expect, actual) {
t.Fatalf("got unexpected value\nexpect: %s\nactual: %s", Stringify(expect), Stringify(actual))
}
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.PostForm)
fmt.Fprint(w, `{}`)
})
_, err := client.Vote.Remove(ctx, "t3_test")
if err != nil {
t.Fatalf("got unexpected error: %v", err)
}
res, err := client.Vote.Remove(ctx, "t3_test")
assert.NoError(t, err)
assert.Equal(t, http.StatusOK, res.StatusCode)
}