guy176251/reddit-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use require instead of assert for tests

Browse Source 
This makes the test fail and stop execution immediately after an
incorrect assertion.

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
This commit is contained in:
Vartan Benohanian
2020-08-11 16:21:07 -04:00
parent 67cd813e70
commit 728087b874
13 changed files with 926 additions and 926 deletions
Download Patch File Download Diff File Expand all files Collapse all files
moderation_test.go
+36 -36
View File
@@ -7,7 +7,7 @@ import (
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var expectedModActionsResult = &ModActions{
@@ -54,16 +54,16 @@ func TestModerationService_GetActions(t *testing.T) {
defer teardown()
blob, err := readFileContents("testdata/moderation/actions.json")
assert.NoError(t, err)
require.NoError(t, err)
mux.HandleFunc("/r/testsubreddit/about/log", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodGet, r.Method)
require.Equal(t, http.MethodGet, r.Method)
fmt.Fprint(w, blob)
})
result, _, err := client.Moderation.GetActions(ctx, "testsubreddit", nil)
assert.NoError(t, err)
assert.Equal(t, expectedModActionsResult, result)
require.NoError(t, err)
require.Equal(t, expectedModActionsResult, result)
}
func TestModerationService_GetActionsByType(t *testing.T) {
@@ -71,24 +71,24 @@ func TestModerationService_GetActionsByType(t *testing.T) {
defer teardown()
blob, err := readFileContents("testdata/moderation/actions.json")
assert.NoError(t, err)
require.NoError(t, err)
mux.HandleFunc("/r/testsubreddit/about/log", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodGet, r.Method)
require.Equal(t, http.MethodGet, r.Method)
form := url.Values{}
form.Set("type", "testtype")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
fmt.Fprint(w, blob)
})
result, _, err := client.Moderation.GetActionsByType(ctx, "testsubreddit", "testtype", nil)
assert.NoError(t, err)
assert.Equal(t, expectedModActionsResult, result)
require.NoError(t, err)
require.Equal(t, expectedModActionsResult, result)
}
func TestModerationService_AcceptInvite(t *testing.T) {
@@ -96,23 +96,23 @@ func TestModerationService_AcceptInvite(t *testing.T) {
defer teardown()
blob, err := readFileContents("testdata/moderation/actions.json")
assert.NoError(t, err)
require.NoError(t, err)
mux.HandleFunc("/r/testsubreddit/api/accept_moderator_invite", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("api_type", "json")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
fmt.Fprint(w, blob)
})
_, err = client.Moderation.AcceptInvite(ctx, "testsubreddit")
assert.NoError(t, err)
require.NoError(t, err)
}
func TestModerationService_Approve(t *testing.T) {
@@ -120,18 +120,18 @@ func TestModerationService_Approve(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/approve", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
})
_, err := client.Moderation.Approve(ctx, "t3_test")
assert.NoError(t, err)
require.NoError(t, err)
}
func TestModerationService_Remove(t *testing.T) {
@@ -139,19 +139,19 @@ func TestModerationService_Remove(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/remove", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
form.Set("spam", "false")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
})
_, err := client.Moderation.Remove(ctx, "t3_test")
assert.NoError(t, err)
require.NoError(t, err)
}
func TestModerationService_RemoveSpam(t *testing.T) {
@@ -159,19 +159,19 @@ func TestModerationService_RemoveSpam(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/remove", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t3_test")
form.Set("spam", "true")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
})
_, err := client.Moderation.RemoveSpam(ctx, "t3_test")
assert.NoError(t, err)
require.NoError(t, err)
}
func TestModerationService_Leave(t *testing.T) {
@@ -179,18 +179,18 @@ func TestModerationService_Leave(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/leavemoderator", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t5_test")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
})
_, err := client.Moderation.Leave(ctx, "t5_test")
assert.NoError(t, err)
require.NoError(t, err)
}
func TestModerationService_LeaveContributor(t *testing.T) {
@@ -198,16 +198,16 @@ func TestModerationService_LeaveContributor(t *testing.T) {
defer teardown()
mux.HandleFunc("/api/leavecontributor", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodPost, r.Method)
require.Equal(t, http.MethodPost, r.Method)
form := url.Values{}
form.Set("id", "t5_test")
err := r.ParseForm()
assert.NoError(t, err)
assert.Equal(t, form, r.Form)
require.NoError(t, err)
require.Equal(t, form, r.Form)
})
_, err := client.Moderation.LeaveContributor(ctx, "t5_test")
assert.NoError(t, err)
require.NoError(t, err)
}