guy176251/reddit-go
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use require instead of assert for tests

Browse Source 
This makes the test fail and stop execution immediately after an
incorrect assertion.

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
This commit is contained in:
Vartan Benohanian
2020-08-11 16:21:07 -04:00
parent 67cd813e70
commit 728087b874
13 changed files with 926 additions and 926 deletions
Download Patch File Download Diff File Expand all files Collapse all files
reddit_test.go
+5 -5
View File
@@ -11,7 +11,7 @@ import (
"reflect"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var (
@@ -83,13 +83,13 @@ func testClientServices(t *testing.T, c *Client) {
cv := reflect.Indirect(cp)
for _, s := range services {
assert.Falsef(t, cv.FieldByName(s).IsNil(), "c.%s should not be nil", s)
require.Falsef(t, cv.FieldByName(s).IsNil(), "c.%s should not be nil", s)
}
}
func testClientDefaultUserAgent(t *testing.T, c *Client) {
expectedUserAgent := fmt.Sprintf("golang:%s:v%s (by /u/)", libraryName, libraryVersion)
assert.Equal(t, expectedUserAgent, c.userAgent)
require.Equal(t, expectedUserAgent, c.userAgent)
}
func testClientDefaults(t *testing.T, c *Client) {
@@ -99,7 +99,7 @@ func testClientDefaults(t *testing.T, c *Client) {
func TestNewClient(t *testing.T) {
c, err := NewClient(nil)
assert.NoError(t, err)
require.NoError(t, err)
testClientDefaults(t, c)
}
@@ -109,5 +109,5 @@ func TestNewClient_Error(t *testing.T) {
}
_, err := NewClient(nil, errorOpt)
assert.EqualError(t, err, "foo")
require.EqualError(t, err, "foo")
}