Remove FromEnv option, a few todos

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-27 18:15:45 -04:00
parent c4faa00b94
commit a14cb3a3c8
7 changed files with 8 additions and 64 deletions
@@ -119,6 +119,11 @@ func NewClient(creds *Credentials, opts ...Opt) (*Client, error) {
 	}

 	client := newClient()
+	client.ID = creds.ID
+	client.Secret = creds.Secret
+	client.Username = creds.Username
+	client.Password = creds.Password
+
 	for _, opt := range opts {
 		if err := opt(client); err != nil {
 			return nil, err
@@ -156,11 +161,6 @@ func NewClient(creds *Credentials, opts ...Opt) (*Client, error) {
 		}
 	}

-	client.ID = creds.ID
-	client.Secret = creds.Secret
-	client.Username = creds.Username
-	client.Password = creds.Password
-
 	oauthTransport := oauthTransport(client)
 	client.client.Transport = oauthTransport