Return errors on nil credentials, move code around

Signed-off-by: Vartan Benohanian <vartanbeno@gmail.com>
2020-08-27 00:29:53 -04:00
parent c0f0cf8be6
commit c4faa00b94
6 changed files with 110 additions and 104 deletions
@@ -92,17 +92,20 @@ func testClientDefaults(t *testing.T, c *Client) {
 }

 func TestNewClient(t *testing.T) {
-	c, err := NewClient(nil)
+	c, err := NewClient(&Credentials{})
 	require.NoError(t, err)
 	testClientDefaults(t, c)
 }

 func TestNewClient_Error(t *testing.T) {
+	_, err := NewClient(nil)
+	require.EqualError(t, err, "must provide credentials to initialize *reddit.Client")
+
 	errorOpt := func(c *Client) error {
 		return errors.New("foo")
 	}

-	_, err := NewClient(nil, errorOpt)
+	_, err = NewClient(&Credentials{}, errorOpt)
 	require.EqualError(t, err, "foo")
 }